Topic: NRS v1.4.17 (Read 26151 times)

Jean-Luc · « **on:** April 19, 2015, 07:48:26 am »

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Release 1.4.17

https://bitbucket.org/JeanLucPicard/nxt/downloads/nxt-client-1.4.17.zip

sha256:

baf2eed8fb1b677b735c04a4b34efc506e8e9a091ae0c66e5dab767a31d60f6e nxt-client-1.4.17.zip

Change log:

This is a critical bugfix release. Everyone is required to update.

Fixed validation of asset exchange order cancellations.

Fixed excessive memory usage in unconfirmed transaction processing.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBAgAGBQJVM1nhAAoJEFOhyXc7+e2AoOwQAKYni5TVfMh6CndO/hkJCT1i
G5Pg+Abqnx/cE8d6l2j/FIov5eCSCN66Sjva65EFh2wxuYWnSDEXHYf+LBO1bxh4
ZSSbOdUECPapQk2S5byggPBYpxW4PnNnyFF5xaxTYWoASs+RUsap3T0ZzyLprq2c
+NdJ4McFyBIwRSQESzY4SDSKD6vI1umby1eJraCa7ES99JJcu3s/3BnjoH8FIf7l
CHmw6t7q7iVnAeQFep3BJxnIe7Pqr7+XlhU2uZ1wyb2WyJBPQj4fSqOISUmtqIhD
ayemgEOWDh0KQAvE949kO9V97Mf13y5DSonkdWzMjcEbE/lAKuUShh9eJ0URnM+9
VKreVgGwm0yCdw0rBw+z/2x6pQbrp+MTU6EShbdCUCJv7dqHCpeIi4h/Gklog/8I
kKjWzCfFcvRCnLRP7U2MGAb8P+zAeYuRRHic1A6xl8Cp1p685dm3fg80ZvahpgQr
0QLHKtrZGEs3cAQwUo/4CrTExFoYjqtyYYX0LuYjQrXrLELWis+yjxKzf8Iq3BDf
oaWHezwb7aLIoWFGSs3Jxv61Zo20YMfMZqom9M/DE8usapShIZ1Gkto93XYjUFkl
r1DyqQPKfSRJHKoYZt42+TnkhnWkkgP1+KAMf/WH6NZTVQ7Pvs7LjSGnwAxyZ0tS
EMzX2idJXJpeqleZmLZo
=5qu9
-----END PGP SIGNATURE-----

martismartis · « **Reply #1 on:** April 19, 2015, 07:52:46 am »

Is there coming fix also for 1.5.x version?

Jean-Luc · « **Reply #2 on:** April 19, 2015, 08:01:20 am »

Just don't forge with 1.5 until the next version comes out.

abctc · « **Reply #3 on:** April 19, 2015, 08:31:38 am »

Quote from: Jean-Luc on April 19, 2015, 07:48:26 am

.. required to update.

- done.
A lot of "FINE: Invalid tx from ..." messages.

Thank you very much!

crimi · « **Reply #4 on:** April 19, 2015, 08:38:12 am »

related to...

https://nxtforum.org/index.php?topic=8858.msg174689#msg174689

i guess...

allwelder · « **Reply #5 on:** April 19, 2015, 09:13:13 am »

Thanks.
Updated.

bahamapascal · « **Reply #6 on:** April 19, 2015, 11:10:24 am »

Super fast fix, thanks.

Updated

lopalcar · « **Reply #7 on:** April 19, 2015, 11:18:26 am »

Just updated mi raspi node and I'm getting this:

Code: [Select]

     at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:744)
2015-04-19 13:06:19 FINE: Invalid transaction from peer: {"senderPublicKey":"0d14daf255d71eb7761a5948e87e25718793c02cf4183c3eb072767e73cefd7a","attachment":{"version.BidOrderCancellation":1,"order":"7703864326612215322"},"amountNQT":0,"subtype":5,"signature":"db6e43ae0024bba93daf3c3991699b77500ade083351527e71aa5c8dcf8f0605d1ab4e6f44107548ac644c260b009b71a9e18e246b92805ec6b48c28a90ae589","feeNQT":100000000,"ecBlockHeight":407116,"type":2,"deadline":1440,"version":1,"timestamp":44101147,"ecBlockId":"8251117142693288728"}
nxt.NxtException$NotValidException: Order 7703864326612215322 was created by account 18139874131270454714
        at nxt.TransactionType$ColoredCoins$6.validateAttachment(TransactionType.java:1169)
        at nxt.Attachment$AbstractAttachment.validate(Attachment.java:34)
        at nxt.TransactionImpl.validate(TransactionImpl.java:799)
        at nxt.TransactionProcessorImpl.processPeerTransactions(TransactionProcessorImpl.java:451)
        at nxt.TransactionProcessorImpl.access$500(TransactionProcessorImpl.java:34)
        at nxt.TransactionProcessorImpl$5.run(TransactionProcessorImpl.java:209)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:744)
2015-04-19 13:06:19 FINE: Invalid transaction from peer: {"senderPublicKey":"0d14daf255d71eb7761a5948e87e25718793c02cf4183c3eb072767e73cefd7a","attachment":{"version.AskOrderCancellation":1,"order":"15221841308974142518"},"amountNQT":0,"subtype":4,"signature":"c8565e3857033230e95743dec11f282eae8e36a554c82c4230d8f4f051ba2e01c9d73fd7c8f653ec8c80958be2751db8d5f252ffd044dd427b46ab8b67932126","feeNQT":100000000,"ecBlockHeight":407116,"type":2,"deadline":1440,"version":1,"timestamp":44101072,"ecBlockId":"8251117142693288728"}
nxt.NxtException$NotValidException: Order 15221841308974142518 was created by account 13028700997177068196
        at nxt.TransactionType$ColoredCoins$5.validateAttachment(TransactionType.java:1127)
        at nxt.Attachment$AbstractAttachment.validate(Attachment.java:34)
        at nxt.TransactionImpl.validate(TransactionImpl.java:799)
        at nxt.TransactionProcessorImpl.processPeerTransactions(TransactionProcessorImpl.java:451)
        at nxt.TransactionProcessorImpl.access$500(TransactionProcessorImpl.java:34)
        at nxt.TransactionProcessorImpl$5.run(TransactionProcessorImpl.java:209)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:744)
2015-04-19 13:06:19 FINE: Blacklisting 151.236.29.228 because of: nxt.NxtException$NotValidException: Peer sends invalid transactions: [nxt.NxtException$NotValidException: Order 10204133629772644399 was created by account 10080164044348861925, nxt.NxtException$NotValidException: Order 2391401643772354618 was created by account 8509817931916536660, nxt.NxtException$NotValidException: Order 12482249061470521751 was created by account 1721726524996364279, nxt.NxtException$NotValidException: Order 14364617566079028259 was created by account 10544815516691670767, nxt.NxtException$NotValidException: Order 12406971793210673432 was created by account 977041353490674126, nxt.NxtException$NotValidException: Order 13474016488207777832 was created by account 16154703371776302422, nxt.NxtException$NotValidException: Order 3604081559703224534 was created by account 7576874207935798624, nxt.NxtException$NotValidException: Order 853494369369662888 was created by account 17539861187634612390, nxt.NxtException$NotValidException: Order 9451568894572930755 was created by account 1232307066044380252, nxt.NxtException$NotValidException: Order 6612537450211866969 was created by account 1232307066044380252, nxt.NxtException$NotValidException: Order 6642828057401009321 was created by account 6785084810899231190, nxt.NxtException$NotValidException: Order 7703864326612215322 was created by account 18139874131270454714, nxt.NxtException$NotValidException: Order 15221841308974142518 was created by account 13028700997177068196]
nxt.NxtException$NotValidException: Peer sends invalid transactions: [nxt.NxtException$NotValidException: Order 10204133629772644399 was created by account 10080164044348861925, nxt.NxtException$NotValidException: Order 2391401643772354618 was created by account 8509817931916536660, nxt.NxtException$NotValidException: Order 12482249061470521751 was created by account 1721726524996364279, nxt.NxtException$NotValidException: Order 14364617566079028259 was created by account 10544815516691670767, nxt.NxtException$NotValidException: Order 12406971793210673432 was created by account 977041353490674126, nxt.NxtException$NotValidException: Order 13474016488207777832 was created by account 16154703371776302422, nxt.NxtException$NotValidException: Order 3604081559703224534 was created by account 7576874207935798624, nxt.NxtException$NotValidException: Order 853494369369662888 was created by account 17539861187634612390, nxt.NxtException$NotValidException: Order 9451568894572930755 was created by account 1232307066044380252, nxt.NxtException$NotValidException: Order 6612537450211866969 was created by account 1232307066044380252, nxt.NxtException$NotValidException: Order 6642828057401009321 was created by account 6785084810899231190, nxt.NxtException$NotValidException: Order 7703864326612215322 was created by account 18139874131270454714, nxt.NxtException$NotValidException: Order 15221841308974142518 was created by account 13028700997177068196]
        at nxt.TransactionProcessorImpl.processPeerTransactions(TransactionProcessorImpl.java:478)
        at nxt.TransactionProcessorImpl.access$500(TransactionProcessorImpl.java:34)
        at nxt.TransactionProcessorImpl$5.run(TransactionProcessorImpl.java:209)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:744)

Checked two random orders and they are AE operations with many confirmations, is this normal? Keeps appearing symilar logs after reboot the server several times

Jean-Luc · « **Reply #8 on:** April 19, 2015, 11:35:47 am »

The error messages are normal, those are the invalid transactions that must be rejected. After all peers upgrade to 1.4.17, nobody will be sending them around and the messages will stop. More likely, in 24h those transactions will expire and will get dropped for that reason.

lopalcar · « **Reply #9 on:** April 19, 2015, 11:42:13 am »

Quote from: Jean-Luc on April 19, 2015, 11:35:47 am

The error messages are normal, those are the invalid transactions that must be rejected. After all peers upgrade to 1.4.17, nobody will be sending them around and the messages will stop. More likely, in 24h those transactions will expire and will get dropped for that reason.

But they are already confirmed transactions with more than 3k confirmations

How can they be rejected?

Jean-Luc · « **Reply #10 on:** April 19, 2015, 11:59:14 am »

It is not those existing order transactions that are invalid, but the transactions that try to cancel them.

lopalcar · « **Reply #11 on:** April 19, 2015, 12:15:31 pm »

Quote from: Jean-Luc on April 19, 2015, 11:59:14 am

It is not those existing order transactions that are invalid, but the transactions that try to cancel them.

Ahhh ok, obvious, understood, thanks!

starik69 · « **Reply #12 on:** April 19, 2015, 03:21:15 pm »

Never seen this before:

Code: [Select]

Blockchain download halted,
no connection

lurker10 · « **Reply #13 on:** April 19, 2015, 07:41:10 pm »

I notice that peers running 1.4.17 keep sending around invalid transactions and get blacklisted, the log is full of these errors. Is this correct behavior?

NxtSwe · « **Reply #14 on:** April 19, 2015, 08:37:34 pm »

Quote from: lurker10 on April 19, 2015, 07:41:10 pm

I notice that peers running 1.4.17 keep sending around invalid transactions and get blacklisted, the log is full of these errors. Is this correct behavior?

Yea, I get this also, here's an example from nxtportal.org's peer running 1.4.17 (same as I am):

Quote

2015-04-19 22:35:07 FINE: Blacklisting 54.213.222.141 because of: nxt.NxtExcepti
on$NotValidException: Peer sends invalid transactions: [nxt.NxtException$NotVali
dException: Order 10204133629772644399 was created by account 100801640443488619
25, nxt.NxtException$NotValidException: Order 6612537450211866969 was created by
account 1232307066044380252, nxt.NxtException$NotValidException: Order 23914016
43772354618 was created by account 8509817931916536660, nxt.NxtException$NotVali
dException: Order 6642828057401009321 was created by account 6785084810899231190
, nxt.NxtException$NotValidException: Order 9451568894572930755 was created by a
ccount 1232307066044380252, nxt.NxtException$NotValidException: Order 1248224906
1470521751 was created by account 1721726524996364279, nxt.NxtException$NotValid
Exception: Order 15221841308974142518 was created by account 1302870099717706819
6, nxt.NxtException$NotValidException: Order 7703864326612215322 was created by
account 18139874131270454714, nxt.NxtException$NotValidException: Order 13474016
488207777832 was created by account 16154703371776302422, nxt.NxtException$NotVa
lidException: Order 3604081559703224534 was created by account 75768742079357986
24, nxt.NxtException$NotValidException: Order 12406971793210673432 was created b
y account 977041353490674126, nxt.NxtException$NotValidException: Order 85349436
9369662888 was created by account 17539861187634612390, nxt.NxtException$NotVali
dException: Order 14364617566079028259 was created by account 105448155166916707
67]
nxt.NxtException$NotValidException: Peer sends invalid transactions: [nxt.NxtExc
eption$NotValidException: Order 10204133629772644399 was created by account 1008
0164044348861925, nxt.NxtException$NotValidException: Order 6612537450211866969
was created by account 1232307066044380252, nxt.NxtException$NotValidException:
Order 2391401643772354618 was created by account 8509817931916536660, nxt.NxtExc
eption$NotValidException: Order 6642828057401009321 was created by account 67850
84810899231190, nxt.NxtException$NotValidException: Order 9451568894572930755 wa
s created by account 1232307066044380252, nxt.NxtException$NotValidException: Or
der 12482249061470521751 was created by account 1721726524996364279, nxt.NxtExce
ption$NotValidException: Order 15221841308974142518 was created by account 13028
700997177068196, nxt.NxtException$NotValidException: Order 7703864326612215322 w
as created by account 18139874131270454714, nxt.NxtException$NotValidException:
Order 13474016488207777832 was created by account 16154703371776302422, nxt.NxtE
xception$NotValidException: Order 3604081559703224534 was created by account 757
6874207935798624, nxt.NxtException$NotValidException: Order 12406971793210673432
was created by account 977041353490674126, nxt.NxtException$NotValidException:
Order 853494369369662888 was created by account 17539861187634612390, nxt.NxtExc
eption$NotValidException: Order 14364617566079028259 was created by account 1054
4815516691670767]
at nxt.TransactionProcessorImpl.processPeerTransactions(TransactionProce
ssorImpl.java:478)
at nxt.TransactionProcessorImpl.access$500(TransactionProcessorImpl.java
:34)
at nxt.TransactionProcessorImpl$5.run(TransactionProcessorImpl.java:209)

at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask.runAndReset(Unknown Source)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.
access$301(Unknown Source)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.
run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

qq2536007339 · « **Reply #15 on:** April 20, 2015, 01:44:09 am »

Quote from: lurker10 on April 19, 2015, 07:41:10 pm

I notice that peers running 1.4.17 keep sending around invalid transactions and get blacklisted, the log is full of these errors. Is this correct behavior?

Read JL previous reply,this is normal.

NxtSwe · « **Reply #16 on:** April 20, 2015, 06:02:41 am »

Quote from: qq2536007339 on April 20, 2015, 01:44:09 am

Quote from: lurker10 on April 19, 2015, 07:41:10 pm
I notice that peers running 1.4.17 keep sending around invalid transactions and get blacklisted, the log is full of these errors. Is this correct behavior?

Read JL previous reply,this is normal.

It is?
I interpret his reply that 1.4.17 should not pass invalid transactions around, but they seem to be still doing that.

Quote from: Jean-Luc on April 19, 2015, 11:35:47 am

The error messages are normal, those are the invalid transactions that must be rejected. After all peers upgrade to 1.4.17, nobody will be sending them around and the messages will stop. More likely, in 24h those transactions will expire and will get dropped for that reason.

Destroyer · « **Reply #17 on:** April 20, 2015, 06:54:08 am »

hello,
i am the man behind this attack. what you see here is a traditional dos attack and there are a huge number of other flaws in the code as well.
i am willing to share my discoveries for a total of 200.000 nxt payable to the originating account.
i expect nobody will pay for this information because most of the people do not give a shit about this network.
next points to fix:
- classic blockchain fork, ideal to single fork an exchange client and pretend a deposit
- similar DOS attack as the one here

achim · « **Reply #18 on:** April 20, 2015, 07:19:20 am »

Quote from: Destroyer on April 20, 2015, 06:54:08 am

hello,
i am the man behind this attack. what you see here is a traditional dos attack and there are a huge number of other flaws in the code as well.
i am willing to share my discoveries for a total of 200.000 nxt payable to the originating account.
i expect nobody will pay for this information because most of the people do not give a shit about this network.
next points to fix:
- classic blockchain fork, ideal to single fork an exchange client and pretend a deposit
- similar DOS attack as the one here

Welcome to the forum,
Would you bother to sign a token with the Nxt account that you used to perform the attack?

Most of us do give a shit about the network, and we are happy to see guys pointing out flaws.
I'm skeptic that anyone will pay you 200k up front though. Would you be willing to talk to a Nxt dev first about the flaws you found?

abctc · « **Reply #19 on:** April 20, 2015, 07:44:17 am »

Quote from: Destroyer on April 20, 2015, 06:54:08 am

what you see here is a traditional dos attack
...
- similar DOS attack as the one here

to all:
- is it time for us to enable the hallmark protection at our nodes ?

News:

Author Topic: NRS v1.4.17 (Read 26151 times)