elective-stereophonic
elective-stereophonic
Protocol for new feature implementation and significant changes in NXT core.
singapore
Please login or register.

Login with username, password and session length
Advanced search  

News:

Latest Stable Nxt Client: Nxt 1.12.2

Pages: 1 ... 4 5 [6]  All

Author Topic: Protocol for new feature implementation and significant changes in NXT core.  (Read 13904 times)

wesley

  • Hero Member
  • *****
  • Karma: +204/-3
  • Offline Offline
  • Posts: 1159
    • View Profile
Re: Protocol for new feature implementation and significant changes in NXT core.
« Reply #100 on: November 11, 2015, 03:39:33 pm »

They did exist since 1.6.0e I believe. Correct me if I'm wrong. It's just that that was an experimental release not many people updated to.
Logged

abctc

  • Hero Member
  • *****
  • Karma: +148/-13
  • Offline Offline
  • Posts: 1396
    • View Profile
Re: Protocol for new feature implementation and significant changes in NXT core.
« Reply #101 on: November 11, 2015, 03:43:27 pm »

They did exist since 1.6.0e I believe. ...
- they did not:
.. this issue has not been raised on 1.6.0e and following experimental releases because the API has not been depricated. It was still functional as before ..
- if this is true then it is VERY strange and unacceptable.
Jean-Luc, is this true?
The APIs in question have never been deprecated. The change is about the default values only. When the include parameters are supplied, both 1.5 and 1.6 behave the same, and a client of the API updated to be compatible with 1.6 continues to be compatible with 1.5.

The work on changing the default values of include parameters, or adding them where missing, was started in 1.6.1e and there was an "incompatible changes" section in the 1.6.1e changelog. My mistake is that when continuing this work in 1.6.2, there was no "incompatible" warning. Also, the APIs affected by the changes were identified as "all APIs that accept optional "include" parameters to retrieve additional data, e.g. includeCounts, includeAssetInfo, includeCurrencyInfo, and so on", instead of listing all of them specifically, which I agree makes the consequences less obvious.
Logged
Welcome to the Nxt generation of crypto!   Magis quam Moneta (More than a Coin)
"Do not worry, it is an attack" (c) Jean-Luc

Tosch110

  • Hero Member
  • *****
  • Karma: +211/-18
  • Offline Offline
  • Posts: 2365
    • View Profile
Re: Protocol for new feature implementation and significant changes in NXT core.
« Reply #102 on: November 11, 2015, 03:43:56 pm »

Drama has subsided, basically things are sort of back to normal.
Jean-Luc and Riker, could you please confirm that all new features will be pre-announced in future?

coinomat - these changes were announced in 1.6.1e on October 3rd, the release 1.6.2 was on 31st
The section labelled 'Incompatible Changes' in October 3rd post defines the changes.

Does this not constitute pre-announcement. What more did you have in mind, more time?

https://nxtforum.org/index.php?topic=10064.msg195549#msg195549
There were no details in it. The devil is always in the detail. And that API change broke Supernet.

No details? Did you not read the incompatible changes section? It's called "incompatible changes" for a reason ;)

Well it is obvious that it has been either over-read or the consequences underestimated. What would have been more appropriate would have been a post like Jean-Luc provided later: https://nxtforum.org/nrs-releases/nrs-v1-6-2/msg199198/#msg199198

30 days seem like a long timespan but just speaking for me, I went with 1.6.0e and never updated to 1.6.1e. I cannot test every patch, sometimes I am missing the one or other patch. Nxt is not the only software I am working with so an announcement of non-backward compatible API changes is important IMO.

wesley

  • Hero Member
  • *****
  • Karma: +204/-3
  • Offline Offline
  • Posts: 1159
    • View Profile
Re: Protocol for new feature implementation and significant changes in NXT core.
« Reply #103 on: November 11, 2015, 03:56:29 pm »

Yea that's what I meant 1.6.1e sorry.

Anyway it's already been concluded that communication will be improved.
Logged

Jean-Luc

  • Core Dev
  • Hero Member
  • *****
  • Karma: +816/-81
  • Offline Offline
  • Posts: 1610
    • View Profile
Re: Protocol for new feature implementation and significant changes in NXT core.
« Reply #104 on: November 11, 2015, 05:30:25 pm »

And all incompatible changes MUST exist in the code since 1.6.0e, not since 1.6.2.
It should have been called 1.6.2e, or the incompatible changes should have been in 1.6.1e, but this cat is out of the bag now. For the future, we commit to not making any incompatible changes between the last "e" release and the subsequent stable release. But while still within the "e" series, there may still be a need for further incompatible changes or tweaks of the already introduced ones, this is why those releases are called experimental after all. Trying to freeze all incompatible changes before even the "0e" release could only unnecessarily delay such releases, and we prefer to push them out for users to try as early as possible.

Should also note that we don't have any plans for incompatible API changes in the near future.

The fee and size changes planned between 1.6.2 and 1.7 (for which I started a few separate threads) are NOT API changes.
Logged
GPG key fingerprint: 263A 9EB0 29CF C77A 3D06  FD13 811D 6940 E1E4 240C
NXT-X4LF-9A4G-WN9Z-2R322

coinomat

  • Hero Member
  • *****
  • Karma: +214/-18
  • Offline Offline
  • Posts: 1520
    • View Profile
Re: Protocol for new feature implementation and significant changes in NXT core.
« Reply #105 on: November 11, 2015, 09:40:24 pm »

And all incompatible changes MUST exist in the code since 1.6.0e, not since 1.6.2.
It should have been called 1.6.2e, or the incompatible changes should have been in 1.6.1e, but this cat is out of the bag now. For the future, we commit to not making any incompatible changes between the last "e" release and the subsequent stable release. But while still within the "e" series, there may still be a need for further incompatible changes or tweaks of the already introduced ones, this is why those releases are called experimental after all. Trying to freeze all incompatible changes before even the "0e" release could only unnecessarily delay such releases, and we prefer to push them out for users to try as early as possible.

Should also note that we don't have any plans for incompatible API changes in the near future.

The fee and size changes planned between 1.6.2 and 1.7 (for which I started a few separate threads) are NOT API changes.
Glad to hear that, thank you. That's more or less what I wanted to hear.
No one wants to make you do things you don't want to do.  I'd just like to avoid any unnecessary drama in future, it really hurts NXT.

« Last Edit: November 12, 2015, 08:34:31 am by coinomat »
Logged
Time to go further

chanc3r

  • Hero Member
  • *****
  • Karma: +124/-50
  • Offline Offline
  • Posts: 1019
  • NXTInspect
    • View Profile
Re: Protocol for new feature implementation and significant changes in NXT core.
« Reply #106 on: November 11, 2015, 09:51:38 pm »


The fee and size changes planned between 1.6.2 and 1.7 (for which I started a few separate threads) are NOT API changes.

For system users of the blockchain especially if you make extensive use of Permanent AM's I strongly encourage you to read the stuff J-L is posting on this - these changes are MORE fundamental to what NXT will let you do than the frankly cosmetic changes to the APIs that caused so much heat and noise around 1.6.2...

The NXT core dev have promised to be better at telliing us what they are doing, we need to be better at understanding the implications of this.
Logged
NXT: 29996814460165 (NXT-JTA7-B2QR-8BFC-2V222)
@imrimr @NXTinspect
Pages: 1 ... 4 5 [6]  All
 

elective-stereophonic
elective-stereophonic
assembly
assembly